Modify

Opened 6 years ago

Last modified 6 years ago

#1010 new enhancement

ExternalLibraries/MPI should check that MPI_DIR points to a valid directory

Reported by: Ian Hinder Owned by:
Priority: minor Milestone:
Component: EinsteinToolkit thorn Version:
Keywords: Cc:

Description

The MPI thorn currently does not check that MPI_DIR points to a valid directory. The attached patch fixes this and also prints a message containing the (possibly inferred) location of the MPI installation.

OK to apply?

Attachments (1)

0001-configure.sh-Check-that-directory-in-MPI_DIR-exists-.patch (1.1 KB) - added by Ian Hinder 6 years ago.

Download all attachments as: .zip

Change History (2)

comment:1 Changed 6 years ago by Erik Schnetter

The message "Found MPI in ..." is the same as when thorn MPI actually looks for MPI; this is confusing, because people won't know which path printed the message.

On some machine there is no specific MPI directory, e.g. on Crays. (This is similar to Intel's MKL library that is used by passing the "-mkl" flag to the compiler instead of specifying a particular directory.) Currently I specify "NO_BUILD" for MPI_DIR there. This or something equivalent should also be supported.

I'm not sure how much checking we want to do on user configuration input. For example, we could also check whether the include and library directories exist, or whether there is a file mpi.h in the include path, or whether the specified libraries exist. Of course, these may also exist in standard system locations (so will be found automatically), etc., so things are complicated.

On Mac OS X with MacPorts, OpenMPI is installed in a strange way, and we specify the include and library paths directly. Thus the actual content of MPI_DIR will be ignored, so checking that it exists doesn't add value.

What we probably should do instead is to build (and run?) a small MPI program to see whether things work correctly. Since we already know how to build a library this shouldn't be difficult to do.

Maybe we should also have a configuration option specifying which MPIRUN to use instead of leaving this to Simfactory.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The ticket will remain with no owner.
Next status will be 'review'.
as The resolution will be set.
to The owner will be changed from (none) to the specified user.
Next status will be 'confirmed'.
The owner will be changed from (none) to anonymous.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.