- changed status to open
- removed comment
Don't log in multiple times for sim sync
Issue #1013
closed
Don't log in twice for "sim sync". This is necessary only to create the sourcebasedir if it does not yet exist, which is necessary only very rarely. Instead, try rsync directly, and if it fails, examine the error message and create the directory if necessary.
This makes simfactory much nicer to use when one cannot setup an ssh agent, i.e. when one has to type in the password or use a token eavery time.
Keyword:
Comments (5)
-
reporter -
- removed comment
This looks good to me. I quickly tested the patch and it seems to work fine. An added bonus is that syncing is now a second or so faster! Please commit.
-
reporter - changed status to open
- removed comment
-
reporter - changed status to resolved
- removed comment
Applied in r1755.
-
- edited description
- changed status to closed
- Log in to comment
The attached patch first calls rsync, and if it fails, calls mkdir, then rsync again.