GRHydro_InitData updates

Comments (8)

1. 

   Roland Haas reporter

   • changed status to open
   • removed comment

   attached patches. combined.patch.gz contains the whole set (and is too large to attach uncompressed). 0001 comes in part1 and part2 since trac will not let me attach it as a whole since it is too large.

   • 2012-08-06T15:22:48+00:00
2. 

   Ian Hinder

   • removed comment

   Is it necessary to attach the test data patch? I would have thought that code change patch was sufficient, along with a comment "test data will be regenerated".

   • 2012-08-06T15:42:24+00:00
3. 

   Erik Schnetter

   • removed comment

   It is nice to ensure that everybody will generate the same test data.

   • 2012-08-06T15:46:15+00:00
4. 

   Roland Haas reporter

   • removed comment

   Actually patch 0001 manages to be above 256k even without test data. 256 is just a bit small it seems. Of course one could argue that one should not generate such big patches and rather have several smaller commits (unless it is something where the patch is huge because files were renamed) but that I think is a different can of worms :-)

   • 2012-08-06T15:54:59+00:00
5. 

   Ian Hinder

   • removed comment

   Replying to [comment:3 eschnett]:

   It is nice to ensure that everybody will generate the same test data.

   How is this different from running the tests after the data has been committed?

   • 2012-08-06T17:31:54+00:00
6. 

   Erik Schnetter

   • removed comment

   It allows testing the patch before it is committed. That is, I can apply the patch and e.g. test it on a strange machine or strange architecture.

   Of course, in reality I trust the patch author, will only read the patch, comment on the general approach taken to address a particular problem, and if there is indeed a problem it will be picked up after it has been applied. In most cases this will be fine.

   • 2012-08-06T18:01:40+00:00
7. 

   Roland Haas reporter

   • changed status to resolved
   • removed comment

   all applied in rev 134 to 150.

   • 2012-08-09T01:31:13+00:00
8. 

   Roland Haas reporter

   • edited description
   • changed status to closed

   • 2019-02-21T20:13:43+00:00
9. Log in to comment