- changed status to open
- removed comment
External library dependencies not taken into account
Issue #1016
closed
I find that dependencies between external libraries are not taken into account when creating the library link order. That is, "REQUIRES" and "OPTIONAL" specifications are ignored.
I believe I have isolated the problem and will propose a patch soon.
Keyword:
Comments (8)
-
reporter
-
- removed comment
This patch at first glance doesn't seem to change anything for thorns declaring an optional dependency. Shouldn't that also be ordered?
-
reporter
- removed comment
At this point, optional dependencies have either been dropped (if not present), or have been turned into required dependencies (if present).
-
- removed comment
This patch also corrects the problem for me.
Why does the patch comment out two lines instead of removing them?
-
reporter
- removed comment
No particular reason.
-
- removed comment
The actual linking order change in the first part looks fine to me, the part that originally said
ES 2011-11-25: I don't understand these lines I don't understand either, and why the call to TopoSort succeeded before I don't understand even know (since the number of arguments was wrong).
In summary: ok to apply.
-
reporter
- changed status to resolved
- removed comment
Applied.
-
- edited description
- changed status to closed
- Log in to comment
This patch corrects the problem for me.