- changed status to open
- removed comment
GRHydro/MoL/TmunuBase: allow grhydro evolution without Tmunu storage
Issue #1019
closed
Since r350 we can't evolve GRHydro without assigning storage for Tmunu. This is far from ideal, since we may want to study only special relativistic effects or to evolve a non-self-gravitating fluid with a live metric. In both cases we don't need storage for Tmunu.
The attached patches fix this problem. It requires to schedule TmunuBase_SetStressEnergyState at Wragh instead of basegrid and before Mol registers any variables.
Keyword: GRHydro
Keyword: MoL
Keyword: TmunuBase
Comments (7)
-
reporter
-
- removed comment
The patch seems harmless enough. However, it touches the schedule, and I am always afraid that this will break something. How well did you test this patch?
-
reporter
- removed comment
I tested with a parameter file that was broken by r350 and it is now fixed after these patches. This parameter file represents a special relativistic MHD test of GRHydro. I am running on my workstation all test suites before and after the patches. I will report on those results here later when they are done.
-
reporter
- removed comment
It doesn't fail any testsuite that it is not already failing. I have attached the test suite results before and after these patches ran at frozenstar, my workstation. Also the MHD par file was run on ranger. Is it ok to apply these patches?
Thanks, Bruno.
-
- changed status to open
- removed comment
Please apply.
-
reporter
- changed status to resolved
- removed comment
-
- changed status to closed
- edited description
- Log in to comment
- Assignee
- –
- Type
- Priority
- Status
- closed
- Component
- EinsteinToolkit thorn
- Milestone
- –
- Version
- –
- Votes
- 0
- Watchers
- 0
