RotatingSymmetry180::poison_boundaries should not check for NaNs

Issue #1043 closed
Roland Haas created an issue

currently poison_boundaries causes RotatingSymmetry180 checks for both the poison value and for nonfinite values in the boundary. It should probably not check for NaN in case there are grid functions that do actually contain nan values near the boundaries (right not I have a run where this is true for ML_BSSN::H where I don't care about the NaNs). RotatingSymmetry's output completely clutters stdout since it list every single nan point it find.

If one wants to check for NaN values in the constraints one can always use NaNChecker so no functionality is lost.

Also RotatingSymmetry might well see NaN values when combined with say ReflectionSymmetry if the NaNs would be overwritten by say a z-reflection symmetry afterwards (I am not sure what the order in which symmetries are applied is).

Keyword: McLachlan

Comments (5)

  1. Erik Schnetter
    • removed comment

    I attach patches that introduce new parameters "check_boundaries". When boundaries are poisoned, they are not automatically checked any more; this now requires setting this parameter as well.

  2. Log in to comment