checkpoint_ID overwrites checkpoint files after each recovery

Issue #1142 closed
Erik Schnetter created an issue

Apparently, the parameter checkpoint_ID overwrites checkpoint files after each recovery, i.e. overwrites the checkpoint file from one which just recovered, potentially damaging this checkpoint file irreversibly e.g. if variables changed in post_recover_variables.

Simfactory's default parameter settings and examples should be changed back to separating restarts from each other, so that this kind of problem is avoided.

Keyword:

Comments (4)

  1. Erik Schnetter reporter
    • changed status to open
    • removed comment

    The attached patch executes the schedule bin CPINITIAL only after initial data setup, not after recovering.

  2. Frank Löffler
    • removed comment

    Shouldn't the function declaration of CallAnalysis contain a 'const' for did_recover (the function definition does)? Otherwise please apply.

  3. Erik Schnetter reporter
    • changed status to resolved
    • removed comment

    No, const applies only to the local variable, hence it doesn't affect the API.

    Applied.

  4. Log in to comment