Modify

Opened 6 years ago

Last modified 20 months ago

#1172 new enhancement

Remove unnecessary exp/log calls in EOS_Omni

Reported by: Erik Schnetter Owned by:
Priority: minor Milestone:
Component: EinsteinToolkit thorn Version:
Keywords: Cc:

Description

EOS_Omni seems to call exp/log more often than necessary in the nuc_eos table lookup routines. Use algebraic identities to remove them.

Attachments (0)

Change History (2)

comment:1 Changed 20 months ago by Frank Löffler

Can you please provide specific examples, or maybe even a patch? I fear otherwise this ticket is just going to rot here.

comment:2 Changed 20 months ago by anonymous

Here is one example:

  barotropiceos_logrho(:) = log10(10.0d0**barotropiceos_logrho(:) * rho_gf)

This code first exponentiates a quantity, and then takes a logarithm. The code contains many other similar expressions. I believe this code was implemented as a literal translation from a publication, without optimizing its numerics.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The ticket will remain with no owner.
Next status will be 'review'.
as The resolution will be set.
to The owner will be changed from (none) to the specified user.
Next status will be 'confirmed'.
The owner will be changed from (none) to anonymous.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.