remove poly_gamma_ini from EOS_Omni

Comments (7)

1. 

   Roland Haas reporter

   • changed status to open
   • removed comment

   • 2013-02-05T19:44:22+00:00
2. 

   Frank Löffler

   • removed comment

   This also relates to #1070. The big question is: is someone actually using the parameter to set different EOS initially and for evolution?

   • 2013-02-06T12:07:07+00:00
3. 

   Roland Haas reporter

   • removed comment

   I have to admit I am not even sure if this is what poly_gamma_ini does or if it is intended to do this. Certainly we have users setting it incorrectly. Also I would think that changing EOS from initial data to evolution is not something that the EOS thorn should do. Removing the parameter will loudly abort while leaving it in in the current fashion gives silently non-sensical results.

   • 2013-02-06T12:28:52+00:00
4. 

   Frank Löffler

   • changed status to open
   • removed comment

   Let's remove this parameter. Usually I would argue that we should not remove it completely but make it a dummy and complain if it is used. However, that is what (more or less) will happen anyway if the parameter is removed.

   • 2013-02-08T12:35:09+00:00
5. 

   Frank Löffler

   • removed comment

   trigger.patch is applied

   • 2013-02-11T11:51:22+00:00
6. 

   Roland Haas reporter

   • changed status to resolved
   • removed comment

   Thank you. Applied in rev 73 (eos_omni), rev 62 (refluxing) and rev 31 (trigger).

   • 2013-02-11T12:22:53+00:00
7. 

   Roland Haas reporter

   • changed status to closed
   • edited description

   • 2019-02-21T20:08:32+00:00
8. Log in to comment