Thorn configuration scripts should not be run if there are missing thorns

Comments (17)

Frank Löffler
- removed comment
- 2014-11-10T10:00:27+00:00
anonymous
- changed status to open
- assigned issue to
- removed comment
- 2014-11-24T10:23:06+00:00
Erik Schnetter
- removed comment
See https://trac.einsteintoolkit.org/ticket/1707.
- 2014-11-25T12:39:48+00:00
Frank Löffler
- changed status to open
- removed comment
https://bitbucket.org/cactuscode/cactus/branch/early_CST_abort
- 2014-11-30T16:22:50+00:00
Roland Haas
- removed comment
Erik is working on making the ExternalLibraries build themselves at the same time as the other thorns in ticket 1707 which is also up for review (the branch https://svn.cactuscode.org/projects/ExternalLibraries/GSL/branches/eschnett/delayed-build seems to have stabilized, at least there were no changes over the weekend).

Are those two approaches both applicable (ie does this patch still make sense assuming that all ExternelLibraries would soon do what GSL is trying to do in Erik's branch)?
- 2014-12-01T00:11:28+00:00
Frank Löffler
- removed comment
Assuming all external libraries are changed (even outside the ET) I don't see the immediate need for this change anymore, true. The only harm I can see, on the other hand, is that Cactus would bail out before it detected all possible errors - but then if it already got errors in that stage, the likelihood that following errors are simply caused by the earlier ones is high.
- 2014-12-01T09:00:31+00:00
Frank Löffler
- changed status to open
- assigned issue to
- removed comment
testing assignment emails
- 2014-12-08T11:20:43+00:00
Frank Löffler
- assigned issue to
- removed comment
testing assignment emails
- 2014-12-08T11:20:52+00:00
Frank Löffler
- assigned issue to
- removed comment
- 2014-12-08T11:27:30+00:00
Frank Löffler
- assigned issue to
- removed comment
- 2014-12-08T11:27:36+00:00
Frank Löffler
- assigned issue to
- removed comment
- 2014-12-08T11:48:56+00:00
Frank Löffler
- assigned issue to
- removed comment
- 2014-12-08T11:49:24+00:00
Frank Löffler
- assigned issue to
- removed comment
- 2014-12-08T13:50:35+00:00
Roland Haas
- removed comment
Can this be closed (see comment:6) due to the changes to ExternalLibraries separationg detection from building?
- 2015-06-09T06:45:01+00:00
Ian Hinder reporter
- changed status to resolved
- removed comment
- 2015-06-09T07:20:16+00:00
Frank Löffler
- removed comment
Yes. Just for the record: the CST aborts early in this case now. I just couldn't find this ticket when I merged the pull request a while back.
- 2015-06-09T09:20:29+00:00
Roland Haas
- edited description
- changed status to closed
- 2019-02-21T20:08:26+00:00
Log in to comment