simfactory doesn't know how to handle 'old' simulations

Comments (12)

1. 

   Frank Löffler reporter

   • changed status to open
   • removed comment

   I could restart using the following change, but I am not sure if this would be the correct way to patch it:

   Index: lib/simlib.py
   ===================================================================
   --- lib/simlib.py       (revision 1990)
   +++ lib/simlib.py       (working copy)
   @@ -830,7 +830,7 @@
        suggested_num_smt = int(GetMachineOption('num-smt'))
        num_smt = simenv.OptionsManager.GetOption('num-smt')
        if num_smt == None:
   -        if existingProperties != None:
   +        if existingProperties != None and existingProperties.numsmt != None:
                num_smt = existingProperties.numsmt
            else:
                num_smt = GetMachineOption('num-smt')
   

   • 2013-02-17T21:56:16+00:00
2. 

   Erik Schnetter

   • removed comment

   This seems correct. Does it work?

   • 2013-02-18T07:31:33+00:00
3. 

   anonymous

   • removed comment

   It seemed to work, but only because the previous (aborted) invocation wrote a new output-000? directory and the next invocation didn't find an old simulation there and didn't try to restart but started anew. oh well. Btw: the same bug also caused already queued simulations to about when they finally started after I updated simfactory.

   This patch now works:

   Index: lib/simlib.py
   ===================================================================
   --- lib/simlib.py       (revision 1990)
   +++ lib/simlib.py       (working copy)
   @@ -831,7 +831,10 @@
        num_smt = simenv.OptionsManager.GetOption('num-smt')
        if num_smt == None:
            if existingProperties != None:
   -            num_smt = existingProperties.numsmt
   +            try:
   +                num_smt = existingProperties.numsmt
   +            except AttributeError:
   +                num_smt = GetMachineOption('num-smt')
            else:
                num_smt = GetMachineOption('num-smt')
        try:
   

   • 2013-02-18T09:45:12+00:00
4. 

   Erik Schnetter

   • removed comment

   The else branch of "if existingProperties != None" is missing.

   • 2013-02-18T10:13:19+00:00
5. 

   Frank Löffler reporter

   • removed comment

   I edited the patch now.

   • 2013-02-18T10:50:33+00:00
6. 

   Erik Schnetter

   • removed comment

   There is no patch any more.

   • 2013-02-18T15:32:04+00:00
7. 

   Frank Löffler reporter

   • removed comment

   I edited the comment which contains the patch. I now also added it as file.

   • 2013-02-21T11:45:54+00:00
8. 

   Erik Schnetter

   • changed status to open
   • removed comment

   Did you test this for both cases (num_smt exists and does not exist)? If so, please apply.

   • 2013-02-21T12:43:37+00:00
9. 

   Frank Löffler reporter

   • removed comment

   I tested when num_smt didn't exist, and it worked. I didn't test for num_smt exists yet, as I don't have such a simulation to restart right now. However, what could go wrong here given the simplicity of the patch? :)

   • 2013-02-21T12:45:28+00:00
10. 

    Frank Löffler reporter

    • removed comment

    Ok to apply?

    • 2013-02-25T11:37:54+00:00
11. 

    Frank Löffler reporter

    • changed status to resolved
    • removed comment

    Committed as of r1995

    • 2013-03-02T22:17:51+00:00
12. 

    Roland Haas

    • changed status to closed
    • edited description

    • 2019-02-21T20:07:37+00:00
13. Log in to comment