GRHydro updates

Issue #1277 closed
Roland Haas created an issue

mostly Christian Reisswig's work on WENO and MP5 reconstruction in GRHydro. One trivial patch to remove a parfile for test output. Will commit on Wednesday unless objections are raised.

Keyword: GRHydro

Comments (5)

  1. Frank Löffler
    • removed comment

    0003 is fine. 0002 contains a line in the makefile with "#GRHydro_TestSync.cc". This doesn't seem to be necessary - some leftover?

    Some of these patches contain tabs. Please convert to spaces because in general GRHydro doesn't use tabs for intendation and mixing is looking ugly (and using tabs for something else is a bad idea).

    0002: GRHydro_MP5Reconstruct_drv() contains calls to CCTK_EQUALS for each 1D line of calling reconstruction. The result of this string comparison should probably be saved first and reused later. However, this is also currently the case for the (W)ENO reconstructions, so it would make sense to do this there as well.

    Didn't "look" at 0004 and 0005, but I assume these testsuites are ok.

  2. Log in to comment