1. Einstein Toolkit Avatar Einstein Toolkit
  2. Einstein Toolkit
  3. tickets
  4. Issues

Piraha's smart_ptr should be in namespace

Issue #1316 closed
Erik Schnetter created an issue

Piraha defines a helper class smart_ptr (and smart_ptr_guts). These should be located in a namespace.

Probably all of Piraha should be in the namespace cctk. As is, any user who tried to use Piraha in a thorn would be out of luck, since the name "piraha" is now globally already taken.

Keyword:

Comments (2)

  1. Erik Schnetter reporter
    • changed status to resolved
    • removed comment

    In addition to these type names there was also a global variable "ptrs".

    I changed Piraha's namespace from "piraha" to "cctki_piraha", as per Cactus naming conventions.

    I moved smart_ptr into this namespace as well.

  3. Log in to comment
Assignee
–
Type
bug
Priority
minor
Status
closed
Component
Cactus
Milestone
ET_2013_05
Version
–
Votes
0
Watchers
0
Jira Software: the preferred issue tracker for Bitbucket. Join the team!