parameter file parser aborts when findeing first error

Comments (11)

1. 

   Roland Haas reporter

   • removed comment

   This still applies even with the piraha based parser. It is particularly annoying on clusters where one cannot run cactus_sim -S fail.par on the login nodes (eg Cray machines).

   • 2017-03-16T12:55:20+00:00
2. 

   Steven R. Brandt

   • removed comment

   I don't know a generic way to recover from a syntax error. My experience is that when compilers try to do this, usually only the first error message is meaningful. I can make specific syntax errors recoverable, however. I could make piraha recover from the specific errors in this file.

   • 2017-03-16T15:25:42+00:00
3. 

   Steven R. Brandt

   • removed comment

   Take a look at the multiple_syntax_errors branch of the flesh and see if it does what you want.

   • 2017-03-16T17:03:31+00:00
4. 

   Steven R. Brandt

   • changed status to open
   • assigned issue to
   • removed comment

   Can I put this in review?

   • 2017-04-06T08:42:39+00:00
5. 

   Roland Haas reporter

   • removed comment

   You can certainly put it up for review. The review report may or may not be "please apply" in the end (by whoever ends up reviewing it which does not have to be me :-)). For review though please either link the pull request here or provide a diff to look at.

   • 2017-04-12T10:19:11+00:00
6. 

   Steven R. Brandt

   • changed status to open
   • removed comment

   • 2017-04-17T10:45:11+00:00
7. 

   Roland Haas reporter

   • changed status to open
   • removed comment

   I added comments on the code to a pull request for the branch that you can find here: https://bitbucket.org/cactuscode/cactus/pull-requests/37/multiple-syntax-errors-enabled-through-a/diff

   Testing functionality I find that it still aborts after the first error, even for the fail.par file attached in this ticket. In fact I have been unable to make it produce more than one syntax error. Would you be able to provide a parameter file where the change in the code makes a difference, please?

   • 2017-04-20T14:29:48+00:00
8. 

   Steven R. Brandt

   • changed status to open
   • removed comment

   Roland, I replied to your comments and issues and pushed a new revision to the branch.

   • 2017-04-21T08:30:10+00:00
9. 

   Frank Löffler

   • changed status to open
   • removed comment

   • 2017-05-17T10:35:05+00:00
10. 

    Steven R. Brandt

    • changed status to resolved
    • removed comment

    Fixed in 441d62bb72f86519a3e1cc947155671f19803fc0 of https://bitbucket.org/cactuscode/cactus.git

    • 2017-05-19T13:11:50+00:00
11. 

    Roland Haas reporter

    • edited description
    • changed status to closed

    • 2019-02-21T20:13:06+00:00
12. Log in to comment