add evolution method "stationary" to ADMBase

Comments (6)

1. 

   Roland Haas reporter

   • changed status to open
   • removed comment

   • 2013-06-29T16:04:12+00:00
2. 

   Erik Schnetter

   • removed comment

   In this context, I do not understand why there should be a difference between "static" and "stationary", and why this difference should include re-applying initial conditions when the grid structure changes... If we do this, it should probably have a different name. Note that this is not restricted to stationary cases, since the initial condition may depend on cctk_time. In that case, one needs to apply the initial conditions at every time step, not only after grid structure changes.

   Thorn Exact offer this feature already. It does so by defining an evolution method that re-applies the initial condition as necessary.

   I suggest two new parameter settings, one for static and one for non-static situations, so that thorn Exact's setting of the evolution method is not necessary any more. These two settings could e.g. be called "reapply-initial-condition-after-grid-structure-changes" and "reapply-initial-condition-at-every-time-step", only much shorter.

   • 2013-07-02T09:09:40+00:00
3. 

   Roland Haas reporter

   • removed comment

   I am fine with a different name for the parameters (and being able to schedule after each time step, I had not though of that possibility).

   To give some context: the desire for this methods stems from testing the Bondi infall where I found that I either spend most of my time in Exact setting up the Schwarzschild metric in every step or have to live with the SYNC due to "static" evolution_method causing prolongation and producing non-exact metric values in the buffer regions, which I found undesirable given that I used an exact background metric.

   Making this a parameter of ADMBase would allow us to use any ID thorn with this rather than only Exact which might be a nice feature (maybe for something like a long disk simulation around a NS provided by the Lorene readers). Resetting the data only after a regrid seems to be only safe for "stationary" ie time independent spactimes, hence the choice of keyword. I agree that this is confusing when compared to "static" keyword that already exists.

   How about "regrid-only" and "frozen-ID" for the two choices "reapply-initial-condition-after-grid-structure-changes" and "reapply-initial-condition-at-every-time-step" ?

   • 2013-07-02T23:09:30+00:00
4. 

   Erik Schnetter

   • changed status to open
   • removed comment

   Let's put the names to a vote on the mailing list, then apply the patch.

   • 2014-02-11T21:36:26+00:00
5. 

   Roland Haas reporter

   • changed status to resolved
   • removed comment

   Applied as rev 80 of ADMBase with names "ID-apply-always" and "ID-apply-regrid".

   • 2014-05-27T10:12:02+00:00
6. 

   Roland Haas reporter

   • edited description
   • changed status to closed

   • 2019-02-21T20:12:55+00:00
7. Log in to comment