1. Einstein Toolkit Avatar Einstein Toolkit
  2. Einstein Toolkit
  3. tickets
  4. Issues

add boost external library to ET

Issue #1410 closed
Roland Haas created an issue

David Radice provided a thorn for Boost (www.boost.org) in 2011 (http://lists.einsteintoolkit.org/pipermail/users/2011-July/001219.html). CarpetLib can use it for its bboxset2 class if the C++ STL does not support all of C++11.

It would thus be nice to include it in the ET. The thorn repo is on github: https://github.com/dradice/Boost

Keyword: Boost

Comments (10)

  2. Erik Schnetter
    • removed comment

    Boost is a high quality library that extends and anticipates C++ language development. It is very useful for many C++ projects.

    On the other hand, Boost is a very large library, and takes a long time to build.

  3. Roland Haas reporter
    • removed comment

    In that case: how about including only donwload instructions in the ET thornlist so that users can uncomment them when Boost is needed. ie:

    # Boost library                                                                                         
!TARGET   = $ARR                                                                                        !TYPE     = git                                                                                         
!AUTH_URL = git@github.com:dradice/Boost.git                                                            
!URL      = git://github.com/dradice/Boost.git                                                          
!REPO_PATH = ../$2                                                                                      
!CHECKOUT =                                                                                             
#ExternalLibraries/Boost

    It does take a while to compile. For some reason it also does not pick up a -j option which I think the other ExternalLibraries see (or do they?).

  4. Erik Schnetter
    • removed comment

    This is a good idea. We do the same already for OpenCL, and there are a few other libraries or thorns that are similarly interesting, such as e.g. PETSc. Removing comments from a thorn list is one way, but we could introduce a better way as well.

  6. Frank Löffler
    • removed comment

    Even though it is commented out, and even though I don't have any objections myself, we should follow our own procedure and vote on inclusion into the toolkit. Even if it is commented out everything mentioned in the thornlist is part of it.

    I propose not reverting the change again, and vote after-the-fact next Monday, expecting a positive result.

  8. Ian Hinder
    • removed comment

    It's not commented out; it broke the build, as the thorn is not in the super-repository. Please comment it out!

    I would also like to propose that we discourage people from using this library. It takes 1 GB of space just for the source files, and a long time to compile, and we don't want to have to go through this pain on slow, space-limited HPC systems if we can avoid it. Would it be possible to just extract the bits that are needed?

  9. Roland Haas reporter
    • removed comment

    I commented it out now. Very sorry. To tell the truth I had originally mixed up the please apply for the PUGH patch for aligned data with Boost but then since it was (supposedly) commented out did not think about it anymore. I would not recommend this to be build by default. I would also try and move it into a subversion repository so that only the current version makes it onto the users disk and not the full history. This would reduce file size (dist is 67MB which is still twice as large as the biggest ExternalLibrary so far [MPI] but at least no longer by an order of magnitude, .git is 406MB) but obviously not help with build time.

  11. Log in to comment
Assignee
Type
enhancement
Priority
minor
Status
closed
Component
Carpet
Milestone
–
Version
development version
Votes
0
Watchers
0
Jira Software: the preferred issue tracker for Bitbucket. Join the team!