CarpetLib 2dedcb0e7340b0682d530dc26e764408b301e3b8 "CarpetLib: Do not reallocate communication buffers; instead, keep them around" breaks QLM qlm-bl.par test

Comments (6)

1. 

   Roland Haas reporter

   • removed comment

   Error message is:

   cactus_sim: /mnt/data/rhaas/postdoc/gr/ET_trunk/configs/sim/build/CarpetLib/commstate.cc:105: comm_state::comm_state(): Assertion `srequests.empty()' failed.
   Rank 0 with PID 6089 received signal 6
   Writing backtrace to qlm-bl/backtrace.0.txt
   cactus_sim: /mnt/data/rhaas/postdoc/gr/ET_trunk/configs/sim/build/CarpetLib/commstate.cc:105: comm_state::comm_state(): Assertion `srequests.empty()' failed.
   

   • 2013-08-11T23:39:56+00:00
2. 

   Erik Schnetter

   • changed status to open
   • removed comment

   Can you try this patch?

   $ git diff
   diff --git a/Carpet/CarpetLib/src/commstate.cc b/Carpet/CarpetLib/src/commstate.
   index 5e9eb91..532461d 100644
   --- a/Carpet/CarpetLib/src/commstate.cc
   +++ b/Carpet/CarpetLib/src/commstate.cc
   @@ -531,6 +531,11 @@ comm_state::~comm_state ()
    {
      DECLARE_CCTK_PARAMETERS;
   
   +  // Note: calling resize(0) instead of clear() ensures that the
   +  // vector capacity does not change
   +  srequests.resize(0);
   +  rrequests.resize(0);
   +  
      for (size_t type=0; type<typebufs.size(); ++type) {
        typebufdesc& typebuf = typebufs.AT(type);
        for (size_t proc=0; proc<typebuf.procbufs.size(); ++proc) {
   

   • 2013-08-12T08:21:41+00:00
3. 

   Seth Hopper

   • removed comment

   I was having this same error. This patch fixes it. Thanks. Seth

   • 2013-08-12T09:53:48+00:00
4. 

   Erik Schnetter

   • changed status to resolved
   • removed comment

   Applied.

   • 2013-08-12T09:56:55+00:00
5. 

   Roland Haas reporter

   • removed comment

   This patch fixes the issue for me. Thank you.

   • 2013-08-12T09:59:30+00:00
6. 

   Roland Haas reporter

   • edited description
   • changed status to closed

   • 2019-02-21T19:53:16+00:00
7. Log in to comment