Carpet commit bc08df4 break tests

Ian Hinder

removed comment

There was a problem in my Jenkins test script. As of a few weeks ago, it parses the output files and puts the error message in the XML file so you can see it easily on the test results page (e.g. https://build.barrywardell.net/job/EinsteinToolkit/824/testReport/(root)/ADMMass/tov_carpet_1procs/). However, it did not quote the error message for use as an XML attribute, and this was breaking the test results parser. As a result, Jenkins had no knowledge of the tests, and thought that they didn't run. I added the quoting, and the test system now correctly reports all the failures. Unfortunately there was a few hours lag between Erik's commit, my fixing the test system and Erik fixing the code, as this happened in the evening here.

To avoid duplicated effort in future, maybe it should be standard procedure to notify the users list that one is looking at a particular test failure.

The Jenkins emails do not go to the users list, they go to the test list. Recently, there have been very few test failures, so the volume has been low. If it remains this way for a while, we might consider sending the messages to the users list instead. I'm wary of this though, because it is an automated process, and the users list has a large number of members.

2013-09-26T03:15:26+00:00

Comments (4)

Roland Haas reporter
- changed status to open
- removed comment
- 2013-09-25T16:31:53+00:00
Erik Schnetter
- changed status to resolved
- removed comment
Corrected via a different patch that also cleans up the code.
- 2013-09-25T17:46:44+00:00
Ian Hinder
- removed comment
There was a problem in my Jenkins test script. As of a few weeks ago, it parses the output files and puts the error message in the XML file so you can see it easily on the test results page (e.g. https://build.barrywardell.net/job/EinsteinToolkit/824/testReport/(root)/ADMMass/tov_carpet_1procs/). However, it did not quote the error message for use as an XML attribute, and this was breaking the test results parser. As a result, Jenkins had no knowledge of the tests, and thought that they didn't run. I added the quoting, and the test system now correctly reports all the failures. Unfortunately there was a few hours lag between Erik's commit, my fixing the test system and Erik fixing the code, as this happened in the evening here.

To avoid duplicated effort in future, maybe it should be standard procedure to notify the users list that one is looking at a particular test failure.

The Jenkins emails do not go to the users list, they go to the test list. Recently, there have been very few test failures, so the volume has been low. If it remains this way for a while, we might consider sending the messages to the users list instead. I'm wary of this though, because it is an automated process, and the users list has a large number of members.
- 2013-09-26T03:15:26+00:00
Roland Haas reporter
- changed status to closed
- edited description
- 2019-02-21T20:12:34+00:00
Log in to comment