- changed status to open
- assigned issue to
- removed comment
Invalid integer parameters cause a confusing error message
Issue #1469
closed
If an integer-valued parameter is assigned a value such as 100000000000000000000000 which is too large to fit into an integer, the Piraha parameter parser interprets it as a real and complains
(line 15 of sim.par):
-> Parameter type mismatch INT != REAL
This message is not very helpful. A better error message might be:
(line 15 of sim.par):
-> Parameter MyThorn::mypar cannot be set to the value 10000000000000000000 as this is not a valid INT value
Keyword:
Comments (9)
-
-
- removed comment
Please check to see if the attached patch makes things better.
-
- assigned issue to
- removed comment
-
- changed status to resolved
- removed comment
-
- changed status to open
- removed comment
This seems to trigger a lot of testsuite failures, e.g., https://build.barrywardell.net/job/EinsteinToolkit/lastBuild/testReport/junit/%28root%29/GRHydro/tov_slowsector_1procs/
-
reporter
- removed comment
If a fix is not immediately obvious, this should be reverted. It means the flesh is broken, which is quite serious, and not supposed to happen :(
-
reporter
-
- changed status to resolved
- removed comment
Fixed. Very sorry everyone.
This new version definitely solves the problem. It detects values out of range for both double and int.
-
- edited description
- changed status to closed
- Log in to comment
- Assignee
- Type
- Priority
- Status
- closed
- Component
- Cactus
- Milestone
- –
- Version
- development version
- Votes
- 0
- Watchers
- 0
