Modify

Opened 5 years ago

Last modified 4 years ago

#1481 new defect

Hidden hard-coded limits on max_l_modes and max_vars in Multipole

Reported by: bernard.j.kelly@… Owned by:
Priority: minor Milestone:
Component: EinsteinToolkit thorn Version:
Keywords: Multipole Cc:

Description

The EinsteinAnalysis/Multipole thorn has hard-coded limits (in src/multipole.cc) on the number of grid functions that can be decomposed (max_vars) and how high in polar quantum number this decomposition can go (max_l_modes). However, these are not reflected in the thorn's param.ccl.

In fact, param.ccl contains a parameter "l_max", allowing it to be *any* positive value, and doesn't test this against max_l_modes until execution of this source. Wouldn't it make more sense to impose max_l_modes immediately at PARAMCHECK?

To make the actual limit on interpolated functions explicit, a number of desired interpolants could be set in param.ccl (like "n_variables") --- limited if necessary to a hard-coded number that appears as a limit in the range. If the user tries to set n_variables too high, it gets caught at PARAMCHECK; if (s)he accidentally includes too many entries in the "variables" parameter, the extra ones would just be silently ignored.

Attachments (0)

Change History (4)

comment:1 Changed 5 years ago by Frank Löffler

Milestone: ET_2013_11ET_2014_05

comment:2 Changed 5 years ago by Frank Löffler

Milestone: ET_2014_05ET_2014_11

comment:3 Changed 4 years ago by Frank Löffler

Priority: majorminor

comment:4 Changed 4 years ago by Frank Löffler

Milestone: ET_2014_11
Version: ET_2013_05

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The ticket will remain with no owner.
Next status will be 'review'.
as The resolution will be set.
to The owner will be changed from (none) to the specified user.
Next status will be 'confirmed'.
The owner will be changed from (none) to anonymous.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.