Modify

Opened 5 years ago

Last modified 15 months ago

#1494 reopened enhancement

Allow skipping of MoL_PostStep and MoL_PseudoEvolutionBoundaries in POSTRESTRICT

Reported by: Ian Hinder Owned by:
Priority: minor Milestone:
Component: Cactus Version: development version
Keywords: Cc:

Description

It is not always necessary to call MoL_PostStep and MoL_PseudoEvolutionBoundaries in POSTRESTRICT, and it can introduce a performance penalty. The main reason for these calls is that restriction does not fill (outer or symmetry) boundary points, and this is usually done in MoL_PostStep. MoL_PseudoEvolutionBoundaries also sets boundary conditions. However, if restriction does not modify boundary points, for example in the case that boundary points are always far from refined regions, there is no reason to apply boundary conditions (e.g. by calling MoL_PostStep) after restriction.

Eventually, Carpet and MoL should be modified to determine automatically whether the BCs need to be applied, but until that is implemented, the attached patch provides parameters for careful users to optimise their simulations in the case where this is safe to do.

Additionally, recalculations performed in MoL_PostStep may replace more accurate restricted values computed on finer grids, leading to a loss of accuracy.

OK to commit?

Attachments (2)

0001-Add-parameters-to-skip-MoL_PostStep-and-MoL_PseudoEv.patch (2.6 KB) - added by Ian Hinder 5 years ago.
0001-Carpet-Add-sync_after_restrict-parameter.patch (1.7 KB) - added by Ian Hinder 5 years ago.

Download all attachments as: .zip

Change History (11)

comment:1 Changed 5 years ago by Erik Schnetter

Status: newreview

Note that "boundaries" include ghost zones. You probably have to sync the restricted grid functions manually.

Okay to apply.

comment:2 Changed 5 years ago by Erik Schnetter

Status: reviewreviewed_ok

comment:3 Changed 5 years ago by Ian Hinder

The attached (untested) patch enables a Carpet sync after restrict determined by a new parameter. I want to test this a bit before committing though.

comment:4 Changed 5 years ago by Roland Haas

Ian: this has been taken care of, yes?

comment:5 Changed 5 years ago by Ian Hinder

No, they have not been committed. In light of the recent changes to sync/restrict handling, I'll have to go back and think about these patches again.

comment:6 Changed 5 years ago by Roland Haas

Ian: did you decide what to do with these?

comment:7 Changed 5 years ago by Ian Hinder

No. The sync-after-restrict patch should not be necessary, as Carpet now either syncs after restriction (cell-centering) or restricts into ghost zones (vertex centering), as far as I remember. The MoL patch probably would still be useful and correct in certain situations, but I would have to think about it more before committing it.

comment:8 Changed 4 years ago by Roland Haas

Status: reviewed_okreopened

Ian is apparently still think on these.

comment:9 Changed 15 months ago by Roland Haas

The MoL patch also affects buffer zones. Since the restricted points will be source points for the prolongation operators (being just next to the buffer points on the fine grid). So not running MoL_PostStep will change values in the buffer zones.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as reopened The ticket will remain with no owner.
Next status will be 'review'.
as The resolution will be set.
to The owner will be changed from (none) to the specified user.
The owner will be changed from (none) to anonymous.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.