Modify

Opened 5 years ago

Last modified 5 years ago

#1520 assigned defect

src/piraha does not adhere to Cactus coding style

Reported by: Roland Haas Owned by: Steven R. Brandt
Priority: optional Milestone:
Component: Other Version: development version
Keywords: Cc:

Description

The sources files in the src/piraha directory do not adhere to the flesh coding style described in http://einsteintoolkit.org/documentation/MaintGuide/MaintGuidech2.html#x4-3000A2 .

It would be very nice if they had GRDOC (or javadoc or doxygen) headers. Also the internal function cctk_PirahaParser should be called CCTKi_PirahaParser instead (ie uppercase CCTK and an added i for internal).

Minor point: smart_ptr.cc should be SmartPtr.cc .

This is a project for rainy evenings I guess :-).

Attachments (0)

Change History (1)

comment:1 Changed 5 years ago by Frank Löffler

Owner: set to Steven R. Brandt
Status: newassigned

Modify Ticket

Change Properties
Set your email in Preferences
Action
as assigned The owner will remain Steven R. Brandt.
Next status will be 'review'.
as The resolution will be set.
to The owner will be changed from Steven R. Brandt to the specified user.
The owner will be changed from Steven R. Brandt to anonymous.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.