Turn CCTK_REAL8 etc. into typedefs

Comments (9)

Erik Schnetter reporter
- changed status to open
- removed comment
- 2014-02-12T09:18:15+00:00
Roland Haas
- changed status to open
- removed comment
The typedefs look fine. Did you also fix an issue with the last #endif in the file not really being include guard but the one belonging to HAVE_CCTK_C_ATTRIBUTE_UNUSED? That had me initially confused reviewing the patch.
- 2014-02-12T17:25:27+00:00
Roland Haas
- removed comment
Hmm. Fails to compile after I applied the patch.
```
/mnt/data/rhaas/postdoc/gr/Zelmani/src/include/cctk_Types.h:96:1: error: unknown type name 'CCTK_INT1_TYPE'
 typedef CCTK_INT1_TYPE CCTK_INT1;
 ^
```
I assume a -realclean will fix this but it should not be required I think since we already ask for a -reconfig.

Correction: apparently I have to run autoconf on it since configure needs to be updated.
- 2014-02-12T17:32:22+00:00
Erik Schnetter reporter
- removed comment
Yes, I also corrected a mixup with #endifs in cctk_Types.h.

Did you also regenerate "configure"? I didn't include this into the patch.
- 2014-02-12T19:55:10+00:00
Roland Haas
- removed comment
Yes, I regenerated configure. I would not compile before (lots of errors since the types were not defined). I also found out why you had all those commits change #ifdef CCTK_REAL4 to #ifdef HAVE_CCTK_REAL4 :-). Since I had not put in the magic words explicitly in the previous review:

Please apply.
- 2014-02-12T20:08:50+00:00
Erik Schnetter reporter
- removed comment
I thought it didn't compile? Does it work for you now?
- 2014-02-12T20:10:44+00:00
Roland Haas
- removed comment
I had to regenerate configure and updated my comment. However since editing a comment does not trigger an email I guess this was lost to the mailing list.
- 2014-02-12T20:13:36+00:00
Erik Schnetter reporter
- changed status to resolved
- removed comment
Applied.
- 2014-02-12T21:16:35+00:00
Roland Haas
- changed status to closed
- edited description
- 2019-02-21T20:11:27+00:00
Log in to comment