Modify

Opened 5 years ago

Last modified 5 years ago

#1546 new defect

LoopControl commit e0ddb732 contains Fortran 2003 code

Reported by: Roland Haas Owned by: Erik Schnetter
Priority: minor Milestone:
Component: Carpet Version: development version
Keywords: Cc:

Description

commit e0ddb732 "LoopControl: Rewrite" from Wed Jan 16 14:46:17 2013 -0500 introduces Fortran 2003 features (namely bind(C) in loopcontrol_types.F90.

This fails to compile with gfortran 4.1.2 (the default gfortran on RH 5 machines, which are still around). David Radice stumbled oppon this.

We had 2003 code in Carpet before, in ticket #670. At that point we modified the code to compile with gfortran 4.1.2 and removed the advanced features. Since gfortran 4.1.2 is by now 4 years old and none of our production option lists show the problem, I think we are finally ready to use some F2003 features in the code.

We should then document this in the release notes, either for Cactus if we want to make this choice system wide or only for the ET/Carpet if we want to support running eg PUGH with only F90 around. We already require C99 in the Cactus flesh.

Possibly we should take this discussion to cactus-devel.

Attachments (0)

Change History (3)

comment:1 Changed 5 years ago by Erik Schnetter

gfortran 4.1.2 was released in 2007, which makes it seven years old (not four).

This version has many other problems as well, and most likely can't compile the Einstein Toolkit anyway. gfortran 4.2 was the first version that was actually usable, and gfortran 4.4 is the first "good" version. I recommend we document that gfortran 4.1 is not supported by Cactus.

comment:2 Changed 5 years ago by Roland Haas

Should we require Fortran 2003 in Cactus (we currently require C99 and a F90 compiler)? Carpet (since it requires LoopControl) already needs a F2003 compiler so nothing should break, we'd be just blessing current practise. See also http://lists.einsteintoolkit.org/pipermail/users/2014-May/003617.html . Fortran 2003 seems to introduce a number of useful tools concerning interaction between Fortran and C code.

comment:3 Changed 5 years ago by Erik Schnetter

I think we should.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain Erik Schnetter.
Next status will be 'review'.
as The resolution will be set.
to The owner will be changed from Erik Schnetter to the specified user.
Next status will be 'confirmed'.
The owner will be changed from Erik Schnetter to anonymous.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.