Modify

Opened 5 years ago

Closed 5 years ago

#1590 closed defect (fixed)

Non ET thorn OutsideMask implicitly defines sqrt as int sqrt()

Reported by: Roland Haas Owned by:
Priority: major Milestone:
Component: Other Version: development version
Keywords: OutsideMask Cc:

Description

OutsideMask neglects to include math.h in src/update_mask.c which causes sqrt() to be implicitly defined as int sqrt() which causes distance estimates to be incorrect (most likely random since a double result is likely returned in some other way than an int result).

Attachments (1)

sqrt.patch (294 bytes) - added by Roland Haas 5 years ago.

Download all attachments as: .zip

Change History (7)

Changed 5 years ago by Roland Haas

Attachment: sqrt.patch added

comment:1 Changed 5 years ago by Roland Haas

Status: newreview

comment:2 Changed 5 years ago by Erik Schnetter

Please do not submit patches like this; they should instead be immediately committed as "obvious", except during a freeze.

comment:3 Changed 5 years ago by Roland Haas

I'd love to. I have however no commit rights to the repository in question. I have asked for access and pointed to this ticket (which is the only reason I created the ticket).

comment:4 Changed 5 years ago by anonymous

Status: reviewreviewed_ok

comment:5 Changed 5 years ago by Frank Löffler

You have the right person to talk to in the office next to you, as I understand. :)

comment:6 Changed 5 years ago by Roland Haas

Resolution: fixed
Status: reviewed_okclosed

Applied as rev 22 of OutsideMask.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The ticket will remain with no owner.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.