Non ET thorn OutsideMask implicitly defines sqrt as int sqrt()

Issue #1590 closed
Roland Haas created an issue

OutsideMask neglects to include math.h in src/update_mask.c which causes sqrt() to be implicitly defined as int sqrt() which causes distance estimates to be incorrect (most likely random since a double result is likely returned in some other way than an int result).

Keyword: OutsideMask

Comments (7)

  1. Erik Schnetter
    • removed comment

    Please do not submit patches like this; they should instead be immediately committed as "obvious", except during a freeze.

  2. Roland Haas reporter
    • removed comment

    I'd love to. I have however no commit rights to the repository in question. I have asked for access and pointed to this ticket (which is the only reason I created the ticket).

  3. Frank Löffler
    • removed comment

    You have the right person to talk to in the office next to you, as I understand. :)

  4. Log in to comment