Modify

Opened 5 years ago

Closed 4 years ago

#1617 closed defect (invalid)

Calls to Accelerator_NotifyDataModified should be paired with calls to Accelerator_RequireInvalidData

Reported by: Steven R. Brandt Owned by:
Priority: minor Milestone: Cactus_4.3.0
Component: EinsteinToolkit thorn Version: development version
Keywords: Cc:

Description

Calls to Accelerator_NotifyDataModified should be paired with calls to Accelerator_RequireInvalidData, otherwise there's a risk of seg fault in Accelerator_NotifyDataModified due to a missing accelerator data structure. MoL fails to do this in Operators.c. Patch attached.

Attachments (1)

mol.patch (1.6 KB) - added by Steven R. Brandt 5 years ago.

Download all attachments as: .zip

Change History (4)

Changed 5 years ago by Steven R. Brandt

Attachment: mol.patch added

comment:1 Changed 5 years ago by Erik Schnetter

Moving the initialization of is_device outside the if block is not necessary. It is also dangerous, because it will not have its correct value there.

The first hunk of interface.ccl does not correspond to the current version in svn; in fact, it seems to correct a severe syntax error. Are you sure you started your diff against the current tree? Are you using "svn diff"?

comment:2 Changed 4 years ago by Roland Haas

Is the actual fix in there (calling Accelerator_RequireInvalidData) still required?

comment:3 Changed 4 years ago by Steven R. Brandt

Resolution: invalid
Status: newclosed

Seems not to be a problem any longer.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The ticket will remain with no owner.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.