remove MOLDOESCOMPLEX from MoL

Issue #1624 closed

Frank Löffler created an issue 2014-05-27

MOLDOESCOMPLEX is an old #define in MoL, and seems to be unused for quite some time now. It also comes with the comment "even using it probably doesn't work" in the commit. I suggest to remove it (removing the code within).

Keyword:

Comments (9)

Frank Löffler reporter
- changed status to open
- removed comment
- 2014-05-27T10:43:33+00:00
Erik Schnetter
- changed status to open
- removed comment
Yes, this should be removed.

In the long term, all linear operations should be performed via MoL_LinearCombination. This routine should be extended to support complex variables as well.
- 2014-06-03T10:25:53+00:00
Erik Schnetter
- removed comment
Actually, this is already implemented in MoL_LinearCombination.
- 2014-06-03T10:41:04+00:00
Frank Löffler reporter
- changed status to open
- removed comment
https://bitbucket.org/cactuscode/cactusnumerical/pull-request/1/mol-remove-not-working-direct-support-for/diff
- 2015-01-26T09:41:24+00:00
Frank Löffler reporter
- changed status to open
- removed comment
Please someone review the quite extensive deletions. It is a lot, but it should be fast (a lot of repetition).
- 2015-01-26T09:42:08+00:00
Ian Hinder
- removed comment
Do the ET tests pass when this change is made?
- 2015-01-26T10:54:34+00:00
Frank Löffler reporter
- removed comment
I only tested on my machine, and there they do.
- 2015-01-26T11:01:05+00:00
Frank Löffler reporter
- changed status to resolved
- removed comment
Merged
- 2015-02-02T09:58:07+00:00
Roland Haas
- changed status to closed
- edited description
- 2019-02-21T20:05:52+00:00
Log in to comment

Assignee: –

Type: enhancement

Priority: minor

Status: closed

Component: EinsteinToolkit thorn

Milestone: –

Version: development version

Votes: 0

Watchers: 0