Modify

Opened 5 years ago

Last modified 3 years ago

#1631 reopened defect

The dgfe branch for McLachlan generates NaNs

Reported by: Jonah Miller <jonah.maxwell.miller@…> Owned by: Erik Schnetter
Priority: optional Milestone:
Component: EinsteinToolkit thorn Version: development version
Keywords: dgfe, mclachlan, gamma driver Cc: Erik Schnetter

Description

When one uses the gamma driver formulation in the dgfe branch of McLachlan and sets the shiftGammaCoefficient to zero, the runtime output has NaNs because the code divides by zero.

A bit of flow control fixes this. Attached is a patch for the branch.

Attachments (1)

fix_gamma_driver.patch (1.7 KB) - added by Jonah Miller <jonah.maxwell.miller@…> 5 years ago.
A patch to fix the gamma driver in BSSN.m

Download all attachments as: .zip

Change History (12)

Changed 5 years ago by Jonah Miller <jonah.maxwell.miller@…>

Attachment: fix_gamma_driver.patch added

A patch to fix the gamma driver in BSSN.m

comment:1 Changed 5 years ago by Erik Schnetter

Status: newreview

comment:2 Changed 5 years ago by Frank Löffler

Status: reviewreviewed_ok

comment:3 Changed 5 years ago by Erik Schnetter

The same problem also exists on the rewrite branch, and the same solution should be applied there.

comment:4 Changed 5 years ago by Jonah Miller <jonah.maxwell.miller@…>

If no one else has started working on this, I can go through the rewrite branch and generate another patch. Just let me know.

comment:5 Changed 5 years ago by Peter Diener

I'm currently working on the compatibility of the rewrite branch with the main branch. In order to reduce the risk of conflicts, please hold off until that is completed.

comment:6 Changed 5 years ago by Jonah Miller <jonah.maxwell.miller@…>

Okay, thanks. I'll keep an eye out for the commit to the main branch.

comment:7 Changed 5 years ago by Peter Diener

This patch doesn't work when applied to the rewrite branch. This is due to vector instructions being used and so the variable shiftGammaCoeffValue is declared as a CCTK_REAL_VEC. Comparing this to a scalar value does not work. The easy fix is to replace shiftGammaCoeffValue with the scalar parameter shiftGammaCoeff. The expression for shiftGammaCoeffValue guarantees that it is zero if shiftGammaCoeff is.

comment:8 Changed 4 years ago by Ian Hinder

Please apply.

comment:9 Changed 4 years ago by Frank Löffler

Milestone: ET_2014_11

comment:10 Changed 3 years ago by Roland Haas

Has there been progress on this? It is still set to "reviewed" and unless the patch actually applies I believe it should be reset to "confirmed" until a new patch is provided.

comment:11 Changed 3 years ago by Roland Haas

Status: reviewed_okreopened

Modify Ticket

Change Properties
Set your email in Preferences
Action
as reopened The owner will remain Erik Schnetter.
Next status will be 'review'.
as The resolution will be set.
to The owner will be changed from Erik Schnetter to the specified user.
The owner will be changed from Erik Schnetter to anonymous.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.