- removed comment
Consider using BitBucket "pull request" feature
Issue #1666
closed
BitBucket allows a user to create a fork (or branch) of a repository and request that it be pulled into the master branch. Comments can be made on the pull request, and the discussion of the change will then be on the BitBucket website, rather than in TRAC. Pull requests are more convenient than patches, as there is no need to manually download and apply patch files, and there is a clear audit trail of what was reviewed and when. However, since not all the ET repositories are in BitBucket, this would lead to fragmentation of the review process, with some changes being discussed in TRAC and some in BitBucket.
(See the discussion at http://lists.einsteintoolkit.org/pipermail/users/2014-October/003816.html regarding notifications of pull requests.)
Discuss.
Keyword:
Comments (3)
-
-
reporter
- changed status to resolved
- removed comment
We have started using pull requests, on the understanding that the discussion happens still in the TRAC ticket, to avoid fragmentation.Closing this ticket as we are now using the feature. I have created #1719 for Barry's Jenkins suggestion.
-
- edited description
- changed status to closed
- Log in to comment
- Assignee
- –
- Type
- Priority
- Status
- closed
- Component
- Server Infrastructure
- Milestone
- –
- Version
- development version
- Votes
- 0
- Watchers
- 0
Another desirable feature would be to have the Jenkins build-and-test system automatically run for pull requests, so that it is clear that they can be merged without breaking anything. I don't know whether this is possible with Bitbucket, but Bitbucket does have Jenkins support and I've seen the "build-and-test of pull requests idea" work well with projects hosted on GitHub. See the [https://github.com/Homebrew/homebrew/pulls Homebrew project] for a good example.