Cactus should exit with a nonzero exit code if an error occurs

In WarnLevel.c, in CCTK_VWarn (called by CCTK_Warn), it says

if (level <= error_level) { CCTK_Abort (NULL, 0); }

The second argument to CCTK_Abort is the exit code of the process. So if there is an "error" warning, the process exits with 0 exit code; i.e. success! This happens in several places in this file.

The user guide does not say anything about the exit code of Cactus. I think that if Cactus has a level-0 warning, i.e. an error, then it should exit with a non-zero exit code, and Erik agrees.

See http://lists.einsteintoolkit.org/pipermail/users/2014-November/003878.html

Keyword:

Comments (5)