Retire snprintf.c

Comments (11)

Erik Schnetter reporter
- changed title to Retire snprintf.c
- removed comment
- 2014-12-01T07:18:44+00:00
Frank Löffler
- removed comment
"approved" as being ok on the ET call today.
- 2014-12-08T13:49:18+00:00
Erik Schnetter reporter
- changed status to resolved
- removed comment
Done.
- 2014-12-08T16:00:01+00:00
Roland Haas
- changed status to open
- removed comment
When retiring snprintf, the related function strdup was also retired. However strdup is not in C99 but in BSD/POSIX and thus is not available by default. In C it is implicitly declared to return int which fails if the actual returned pointer is larger than 32 bits. The branch

https://bitbucket.org/cactuscode/cactus/branch/rhaas%2Fcheck-for-PI-and-strdup

provides configure checks for this routine.
- 2015-03-06T14:05:01+00:00
Roland Haas
- changed status to open
- removed comment
- 2015-03-06T14:05:10+00:00
Erik Schnetter reporter
- removed comment
Regarding strdup: Ouch. Hello 1972, nice to meet you.

Isn't there a gcc warning that requires prototypes for all functions? I think we should be able to enable this safely.
- 2015-03-06T14:19:12+00:00
Roland Haas
- removed comment
There is a gcc warning that one can use for prototypes, however it warns about many benign uses of say printf without prototype. It is also only a warning and I would not want to have to rely on it (or only on its error-ized version from -Werror) to prevent subtle errors (since the wrong prototyped one will work as long as the returned address is less than 2GB) since we have very many other warnings that are triggered when compiling the full set of thorns.
- 2015-04-16T03:16:00+00:00
Roland Haas
- removed comment
Anyone care to review this?
- 2015-06-09T06:42:08+00:00
Erik Schnetter reporter
- changed status to open
- removed comment
- 2015-06-09T08:22:05+00:00
Roland Haas
- changed status to resolved
- removed comment
Applied in git hash 898d23d08a833aa9ebb6c9690765aaa4d6afc436 of the flesh.
- 2015-06-09T09:13:15+00:00
Roland Haas
- changed status to closed
- edited description
- 2019-02-21T20:01:10+00:00
Log in to comment