Avoid build-time warning

Issue #1713 resolved
Erik Schnetter created an issue

I see this warning when building. I assume this should instead be a run-time warning or error?

/Users/eschnett/Cbeta/arrangements/EinsteinEvolve/GRHydro_InitData/src/GRHydro_PoloidalMagFieldM.F90:110:2: warning: #warning "This algorithm does only work on Cartesian grids!!" [-Wcpp]
 #warning "This algorithm does only work on Cartesian grids!!"
  ^

Keyword:

Comments (8)

  1. Ian Hinder
    • changed status to open
    • marked as
    • removed comment

    If the results are always wrong, it should be a fatal error. If it is something that should be implemented, there could be a comment in the code and a ticket created.

  2. Roland Haas

    I have a beautiful patch for this but the comment field is too small to write it down.

    I’ll make a pull request after the release.

  3. Roland Haas

    @Erik Schnetter would you like to review the pull request that addresses the issue you reported?

    Unless objected I will apply this after 2023-03-30

  4. Log in to comment