Test failure in GRHydro's balsara4_1d

Comments (9)

1. 

   Roland Haas

   • removed comment

   This is most likely a tolerance issue. Balsara4 uses a very high Lorentz factor and we already had to increase the tolerance for the 2d version of the test to 1e-8 for Bcom in 4c0d195. The relevant part of test.ccl would be:

   TEST balsara4_1d
   {
           NPROCS 2
           RELTOL 1e-8 grhydro::bcom
           RELTOL 1e-9 hydrobase::w_lorentz
           RELTOL 1e-10 hydrobase::(eps|rho)
   }
   

   Which machine/compiler/options did you use to see the test failure?

   • 2015-01-02T18:27:27+00:00
2. 

   Erik Schnetter reporter

   • removed comment

   This is e.g. OS X or Ubuntu, with gfortran 4.9.2, without optimization.

   • 2015-01-02T19:40:19+00:00
3. 

   Roland Haas

   • removed comment

   Hmm. This is new then. I use gfortran 4.9.2 on my (Debian) workstation and the test passes there (kind of unsurprising since the data was generated on that machine) and I also tested it on a Ubuntu VM shortly after the release. I'll check once more if it still passes or fails and if it fails, when it started to fail.

   • 2015-01-03T15:01:01+00:00
4. 

   Roland Haas

   • removed comment

   Replying to [comment:3 rhaas]:

   Hmm. This is new then. I use gfortran 4.9.2 on my (Debian) workstation and the test passes there (kind of unsurprising since the data was generated on that machine) and I also tested it on a Ubuntu VM shortly after the release. I'll check once more if it still passes or fails and if it fails, when it started to fail.

   Addendum: I tested with optimization though. Unless we are using fast-math with gfortran the results should not differ, but then, Fortran does not really guarantee any particular ordering for floating point evaluations. I'll test with and without optimizations.

   • 2015-01-03T15:02:41+00:00
5. 

   Roland Haas

   • removed comment

   Correction, I use gcc 4.9.1.

   • 2015-01-05T10:43:48+00:00
6. 

   Roland Haas

   • removed comment

   Erik: would those tolerances fix your test failures?

   • 2015-01-25T11:27:08+00:00
7. 

   Erik Schnetter reporter

   • removed comment

   I see this error report:

      grhydro-divb.x.asc: differences below tolerance on 10 lines
      hydrobase-bvec.x.asc: differences below tolerance on 2 lines
      hydrobase-eps.x.asc: differences below tolerance on 30 lines
      hydrobase-press.x.asc: differences below tolerance on 30 lines
      hydrobase-rho.x.asc: substantial differences
         significant differences on 28 (out of 30) lines
         maximum absolute difference in column 13 is 1.15789600130256e-11
         maximum relative difference in column 13 is 1.1578960013032e-11
         (insignificant differences on 2 lines)
      hydrobase-vel.x.asc: differences below tolerance on 30 lines
      hydrobase-w_lorentz.x.asc: substantial differences
         significant differences on 28 (out of 30) lines
         maximum absolute difference in column 13 is 2.58999932611914e-10
         maximum relative difference in column 13 is 1.15799330402901e-11
         (insignificant differences on 2 lines)
   

   Yes, I think these tolerances would avoid this error.

   • 2015-01-25T12:38:12+00:00
8. 

   Roland Haas

   • changed status to resolved
   • removed comment

   Those tolerances were already present however the patterns in test.ccl used the old filenames hydrobase::rho instead of hydrobase-rho. I have updated test.ccl in EinsteinEvolve hash c23d7d8 .

   • 2015-03-21T15:02:39+00:00
9. 

   Roland Haas

   • edited description
   • changed status to closed

   • 2019-02-21T20:00:58+00:00
10. Log in to comment