Opened 4 years ago

Last modified 4 years ago

#1734 new enhancement

New Carpet thorns CarpetTest, TestBBoxSet2, TestTimers2

Reported by: Erik Schnetter Owned by:
Priority: minor Milestone:
Component: EinsteinToolkit thorn Version: development version
Keywords: Cc:


I suggest to add the three existing thorns CarpetTest, TestBBoxSet2, TestTimers2 to the Einstein Toolkit. They contain tests for Carpet.

Attachments (0)

Change History (1)

comment:1 Changed 4 years ago by Ian Hinder

We currently have ~14 Carpet test thorns. Each of these thorns contains approximately one source file each. Why not put all such tests into CarpetTest? Is there an advantage to having modularity at the level of thorns? Alternatively, maybe the tests should go into the tested thorn. That is how the regression tests are handled, after all, and it means that if you have the code, you have the tests, and they will be run automatically. Maybe we need to have a discussion about the best way to have unit tests in the ET, since we have no standards for this at the moment. I would propose that unit tests should be in the tested thorn, and there should be a mechanism for running them as part of the regression tests (e.g. by having a parameter to enable each test, and a test parfile which activates this parameter in the thorn/test directory.

The tests should definitely be added, but I would really prefer that we reduce the large number of test thorns.

Modify Ticket

Change Properties
Set your email in Preferences
as new The ticket will remain with no owner.
Next status will be 'review'.
as The resolution will be set.
to The owner will be changed from (none) to the specified user.
Next status will be 'confirmed'.
The owner will be changed from (none) to anonymous.

Add Comment

E-mail address and name can be saved in the Preferences.

Note: See TracTickets for help on using tickets.