- changed status to open
- removed comment
avoid using Fortran compiler to link Riemann1d utility
GRHydro contains a Riemann1d utility which contains a Fotran90 main program. Unfortunately some of the libraries we link against use C++ code and the F90 compiler fails to link the executable (missing vtables, constructors etc). Since the C++ compiler cannot link the main executable either (since it does not know how to start the main Fotran program), the attached patch adds a stub main() function that calls the previous F90 code as a subroutine. Most of the changes are to the build files to make a utility that needs preprocessed C code (for CCTK_FNAME) and contains multiple object files.
Pull request is: https://bitbucket.org/einsteintoolkit/einsteinevolve/pull-request/5/grhydro-add-c-main-function-for-riemann1d/diff though given that this is a single commit I'd much rather have it be applied than to get a merge for a single commit.
Keyword: GRHydro
Comments (5)
-
-
- changed status to open
- removed comment
Approved.
-
- changed title to avoid using Fortran compiler to link Riemann1d utility
- removed comment
-
reporter - changed status to resolved
- removed comment
Applied in EinsteinEvolve hash 0741b3df70e17d4a762df4cd715eafd43c61d7ad .
-
reporter - edited description
- changed status to closed
- Log in to comment