Modify

Opened 3 years ago

Last modified 3 years ago

#1799 new defect

Missing braces in test.ccl make Cactus tests hang

Reported by: Erik Schnetter Owned by:
Priority: unset Milestone:
Component: Cactus Version: development version
Keywords: Cc:

Description

This file

TEST kasner
{
  NPROCS 2
}

TEST kasner_amr
{
  NPROCS 2
}

TEST no-overlap
{
  NPROCS 2
}

TEST outer-buffers
{
  NPROCS 1
}

TEST overlap
{
  NPROCS 2
}

TEST 64k2

makes the Cactus test suite mechanism hang. I believe the problem is that ParseTestBlock does not handle the case of missing braces well.

Attachments (0)

Change History (1)

comment:1 Changed 3 years ago by Erik Schnetter

This function has several other suspicious lines:

  • It checks for PROVIDES in the beginning; this should likely be TEST instead
  • It uses the expression $data[$line_number] in one place, but $data->[$line_number] in all other places (missing arrow)
  • The outermost if...else construct looks wrong: If the first line contains no opening brace, then all lines until the next closing brace are skipped (why?); if the first line has an opening brace, then the block is interpreted
  • The end-of-file case is apparently not handled anywhere

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The ticket will remain with no owner.
Next status will be 'review'.
as The resolution will be set.
to The owner will be changed from (none) to the specified user.
Next status will be 'confirmed'.
The owner will be changed from (none) to anonymous.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.