Missing braces in test.ccl make Cactus tests hang

Issue #1799 resolved
Erik Schnetter created an issue

This file

TEST kasner
{
  NPROCS 2
}

TEST kasner_amr
{
  NPROCS 2
}

TEST no-overlap
{
  NPROCS 2
}

TEST outer-buffers
{
  NPROCS 1
}

TEST overlap
{
  NPROCS 2
}

TEST 64k2

makes the Cactus test suite mechanism hang. I believe the problem is that ParseTestBlock does not handle the case of missing braces well.

Keyword:

Comments (5)

  1. Erik Schnetter reporter
    • removed comment

    This function has several other suspicious lines: - It checks for PROVIDES in the beginning; this should likely be TEST instead - It uses the expression $data[$line_number] in one place, but $data->[$line_number] in all other places (missing arrow) - The outermost if...else construct looks wrong: If the first line contains no opening brace, then all lines until the next closing brace are skipped (why?); if the first line has an opening brace, then the block is interpreted - The end-of-file case is apparently not handled anywhere

  2. Log in to comment