Modify

Opened 3 years ago

#1808 new task

simplify CarpetLib's data.cc file

Reported by: Roland Haas Owned by: Erik Schnetter
Priority: optional Milestone:
Component: Carpet Version: development version
Keywords: Cc:

Description

CarpetLib's data.cc file contains a number of very large and complex switch statements inside of its transfer_prolongate and transfer_restrict routines (the prolongate one is about 500 lines long and is only one half of an #if CAPRET_DIM preprocessor if statement). The two switch statements also have to be kept in sync with each other whenever a new transport operator is added.

It may be good to instead define some type of "operator package" object that contains the list of prolongation, restrict, time interpolation operators that correspond to a particular choice of transport operator and refinement centering as chosen in the parameter file and interface.ccl.

This way the complex logic could be collected in only a single place. This would be useful since we seem to plan to add more new transport operators to Carpet.

Attachments (0)

Change History (0)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain Erik Schnetter.
Next status will be 'review'.
as The resolution will be set.
to The owner will be changed from Erik Schnetter to the specified user.
Next status will be 'confirmed'.
The owner will be changed from Erik Schnetter to anonymous.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.