add version to LORENE library

Issue #1833 closed

Frank Löffler created an issue 2015-10-26

Now that capabilities can have versions, I propose to give the current LORENE external library the version 2014-04-18: the date the code was pulled from Lorene CVS and added to our repository (according to the log). Since Lorene is (still) in CVS and doesn't use release versions, a date is the best we can do.

Also, I propose to let the three thorns in the ET that use LORENE depend on that version in their configuration.ccl (less or equal than).

Keyword:

Comments (6)

Frank Löffler reporter
- removed comment
- 2015-10-26T13:34:25+00:00
Roland Haas
- removed comment
Does the visible C++ interface change? If not I think we should not require a particular version of LORENE.
- 2015-10-26T13:37:24+00:00
Frank Löffler reporter
- removed comment
The only change I propose here is to give the existing LORENE thorn a version string. The library itself would not change.

Also, following your suggestions from earlier, the actual version string should probably be 2014-04-18-1 - with the "1" indicating an ET-internal version.
- 2015-10-26T13:49:34+00:00
Frank Löffler reporter
- removed comment
Replying to [comment:2 rhaas]:

Does the visible C++ interface change? If not I think we should not require a particular version of LORENE.

Lorene did change it's C++ interface. We don't package that version yet. So, in order to create a "nice" error message for users trying to use the old interface with a newer Lorene thorn, we would have to let the using thorns depend on the old interface, e.g., the old version.
- 2015-10-26T13:51:33+00:00
Frank Löffler reporter
- changed status to resolved
- removed comment
- 2015-10-28T22:53:23+00:00
Roland Haas
- edited description
- changed status to closed
- 2019-02-21T20:07:57+00:00
Log in to comment

Assignee: –

Type: enhancement

Priority: minor

Status: closed

Component: EinsteinToolkit thorn

Milestone: ET_2015_11

Version: development version

Votes: 0

Watchers: 0