AHFinderDirect fix on-off issue setting mask when not finding AH every single step

Comments (10)

Roland Haas reporter
- changed status to open
- removed comment
- 2016-05-01T14:01:51+00:00
Frank Löffler
- removed comment
got comments on bitbucket
- 2016-05-02T01:14:24+00:00
Roland Haas reporter
- removed comment
Are there any more objections to pushing this? I took care of the issues mentioned in the comments in two new commits. Unless there are objections I will push these changes before Saturday.
- 2016-05-06T04:20:18+00:00
Roland Haas reporter
- changed status to resolved
- removed comment
Fixed in git hash b0ae753 of EinsteinAnalysis.
- 2016-05-07T14:01:28+00:00
Roland Haas reporter
- changed status to open
- removed comment
This causes failures in test of Dissipation that use extra dissipation inside of the AH: https://build.barrywardell.net/job/EinsteinToolkitFull/217/testReport/junit/(root)/Dissipation/test_ah_1procs/ and https://build.barrywardell.net/job/EinsteinToolkitFull/217/testReport/junit/(root)/Dissipation/test_ob_1procs/ which are due to changing the scheduling from global (=global-late in ANALYSIS) to global-early. This means that with the change, the apparent horizon is actually recorded correctly in epsdisA. I attach diff files of before (right) and after (left) applying the change. Due to the way loop-local works this is not quite what the code would have seen in EVOL since loop-local loops over all components in all refinement levels not just the ones a local routine would execute on during this timestep.
- 2016-05-16T09:01:45+00:00
Frank Löffler
- removed comment
After talking to Roland: it seems that regenerating the data is the best option, as the old data is clearly wrong, and the new behavior what people intend. It's a case of bad data in test suits.
- 2016-05-17T09:40:37+00:00
Frank Löffler
- changed status to open
- assigned issue to
- changed milestone to ET_2016_05
- removed comment
Roland: can you please regenerate the relevant data files?
- 2016-05-23T09:04:18+00:00
Frank Löffler
- removed comment
The data itself is wrong. Dissipation has a bug. See ~~#1899~~.
- 2016-05-25T14:49:35+00:00
Frank Löffler
- changed status to resolved
- removed comment
- 2016-05-25T15:01:52+00:00
Roland Haas reporter
- edited description
- changed status to closed
- 2019-02-21T20:03:41+00:00
Log in to comment