provide support for multi-model runs in thorn MPI

Comments (5)

1. 

   Roland Haas reporter

   • changed status to open
   • removed comment

   • 2016-05-06T15:49:49+00:00
2. 

   Erik Schnetter

   • removed comment

   Carpet currently provides aliased functions for this. Presumably, all drivers that support multi-model runs could provide such an aliased function. What is the advantage of an explicit function definition in thorn MPI?

   • 2016-11-28T14:20:41+00:00
3. 

   Roland Haas reporter

   • removed comment

   I am no longer sure.

   For C, the functionality is the identical between this and Carpet I think. The code would only collect the functionality on one spot rather than in each driver.

   I think for Fortran, however, Carpet's aliased functions won't work since there is no way to dereference the returned CCTK_POINTER_TO_CONST. The returned pointer is a pointer to the C MPI communicator struct, which (as far as I know) does not have to be bit-identical to Fortran's MPI_Communicator type (which is INT).

   Having said all of this, the original usage case I had for this no longer exists (I think it had to do with running PUGH under LoadLeveler or something similar, I have PUGH/Carpet patches that would make user of this code to provide the aliased functions). The implementation of the Reset functions is also somewhat ugly.

   • 2016-11-28T14:42:31+00:00
4. 

   Roland Haas reporter

   • changed status to resolved
   • removed comment

   Come to think of it, unless there is need for it, I'd keep the complex code out the ET.

   • 2016-11-28T15:16:26+00:00
5. 

   Roland Haas reporter

   • edited description
   • changed status to closed

   • 2019-02-21T20:03:37+00:00
6. Log in to comment