Modify

Opened 3 years ago

Last modified 5 months ago

#1889 reopened defect

correct finding normalization value for relerr compuation

Reported by: Roland Haas Owned by:
Priority: minor Milestone:
Component: Cactus Version: development version
Keywords: Cc:

Description

Before it would have taken the larger of the abs value of the new and
old data of the last data set rather than the largest abs value of the
new and old data of all the datasets.

This will make relative errros smaller and will be particularly
noticeable in cases where the last dataset was small or zero.

This should get rid of the "Error, how did I get here" warnings (that
really indicated an logic error).

Attachments (1)

0001-Cactus-correct-finding-normalization-value-for-reler.patch (1.4 KB) - added by Roland Haas 3 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 3 years ago by Roland Haas

Status: newreview

comment:2 Changed 3 years ago by Roland Haas

Status: reviewreopened

I am no longer sure if this is the right fix. Instead it may be better to compute maxrelerr differently (directly when comparing instead of after the fact).

comment:3 Changed 3 years ago by Roland Haas

Priority: majorminor

Modify Ticket

Change Properties
Set your email in Preferences
Action
as reopened The ticket will remain with no owner.
Next status will be 'review'.
as The resolution will be set.
to The owner will be changed from (none) to the specified user.
The owner will be changed from (none) to anonymous.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.