einsteintoolkit / tickets / issues / #1926 - remove CACHELINE_BYTES and CACHE_SIZE from flesh — Bitbucket

Issue #1926 closed

Frank Löffler created an issue 2016-06-23

Nothing in Cactus uses these variables, and in some cases they are best guesses only. Also, as of 2fb3e32532bbe70121559d582d96b3c300c95276 (Erik Schnetter, Thu Jan 15 12:57:04 2015 -0500), Cactus (the flesh) lost it's ability to overwrite these variables via parameters. Thus, this is a little clean-up within the flesh.

Pull request: https://bitbucket.org/cactuscode/cactus/pull-requests/25/remove-cacheline_bytes-and-cache_size-from/diff

Keyword:

Comments (4)

Frank Löffler reporter
- changed status to open
- removed comment
- 2016-06-23T14:40:20+00:00
Roland Haas
- changed status to open
- removed comment
Fine to apply, please also remove CACHELINE_BYTES related code from simfactory (seems to be in lib/sim-build.py when grep'ing for CACHELINE_BYTES). Consider creating a ticket to remove the corresponding option from simfactory and instead realy on hwloc (or similar) library to query this information at runtime.
- 2016-07-02T09:53:43+00:00
Frank Löffler reporter
- changed status to resolved
- removed comment
- 2016-07-11T09:25:17+00:00
Roland Haas
- changed status to closed
- edited description
- 2019-02-21T20:00:16+00:00
Log in to comment

Assignee: –

Type: enhancement

Priority: minor

Status: closed

Component: Cactus

Milestone: –

Version: development version

Votes: 0

Watchers: 0

Jira Software: the preferred issue tracker for Bitbucket. Join the team!