Modify

Opened 2 years ago

Last modified 2 years ago

#1927 new defect

Add Read/Write tags to TwoPunctures

Reported by: Steven R. Brandt Owned by:
Priority: minor Milestone:
Component: Other Version: development version
Keywords: Cc:

Description

  SCHEDULE TwoPunctures IN TwoPunctures_Group
  {
    LANG: C
    STORAGE: puncture_u bare_mass
    READS: grid::coordinates(EVERYWHERE)
    WRITES: TWOPUNCTURES::puncture_u(INTERIOR)
    WRITES: ADMBASE::METRIC(INTERIOR)
    WRITES: ADMBASE::CURV(INTERIOR)
    WRITES: ADMBASE::alp(INTERIOR)
  } "Create puncture black hole initial data"

Attachments (5)

cactusbase.patch (912 bytes) - added by Steven R. Brandt 2 years ago.
einsteinanalysis.patch (1.4 KB) - added by Steven R. Brandt 2 years ago.
einsteinbase.patch (806 bytes) - added by Steven R. Brandt 2 years ago.
einsteininitialdata.patch (589 bytes) - added by Steven R. Brandt 2 years ago.
mclachlan.patch (1.1 KB) - added by Steven R. Brandt 2 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 2 years ago by Steven R. Brandt

It could be a separate ticket, but CartGrid3D has a similar issue. I'd like to add (Everywhere) to the writes directives in the schedule.ccl

 schedule CartGrid3D_SetCoordinates as SpatialCoordinates at CCTK_POSTREGRID
 {
   LANG: C
-  WRITES: grid::coordinates
+  WRITES: grid::coordinates(everywhere)
 } "Set Coordinates after regridding"

comment:2 Changed 2 years ago by Steven R. Brandt

There are several places in AHFinderDirect where an annotation could be added:

      before AHFinderDirect_find_horizons
      {
      lang: C
+     WRITES: AHFINDERDIRECT::ahmask(EVERYWHERE)
      options: global-early loop-local
      } "import the excision mask"

Changed 2 years ago by Steven R. Brandt

Attachment: cactusbase.patch added

Changed 2 years ago by Steven R. Brandt

Attachment: einsteinanalysis.patch added

Changed 2 years ago by Steven R. Brandt

Attachment: einsteinbase.patch added

Changed 2 years ago by Steven R. Brandt

Attachment: einsteininitialdata.patch added

Changed 2 years ago by Steven R. Brandt

Attachment: mclachlan.patch added

comment:3 Changed 2 years ago by Steven R. Brandt

I decided it made more sense to attach the patch files to correct read/write directives.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The ticket will remain with no owner.
Next status will be 'review'.
as The resolution will be set.
to The owner will be changed from (none) to the specified user.
Next status will be 'confirmed'.
The owner will be changed from (none) to anonymous.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.