Opened 3 years ago

Last modified 3 years ago

#1930 new enhancement

GRHydro_InitData -> HydroBase_InitData?

Reported by: zachetie@… Owned by:
Priority: unset Milestone:
Component: Other Version: development version
Keywords: Cc:


GRHydro_InitData seems to clash with the modern ET approach of making initial data thorns link only to HydroBase/ADMBase (i.e., being evolution-code agnostic), so that any evolution code may take advantage of the functionality.

With slight modifications (possibly requiring the creation of a simple GRHydro compatibility layer thorn, a la "ID_converter_ILGRMHD"), this thorn could be made useful to all HydroBase-compatible GRMHD codes.

Attachments (0)

Change History (1)

comment:1 Changed 3 years ago by Roland Haas

GRHydro_Initdata carries a lot of old baggage from when it was still Whisky_InitData and both primitive and conserved variables lived in the same thorn (Whisky). It also provides more than just ID in, namely the con2prim2con tests.

If you would like to propose changes to remove its tight binding to GRHydro (or separate those out) that would be very useful. The ID-only thorn could be named Hydro_InitData to remove its connection to GRHydro

Modify Ticket

Change Properties
Set your email in Preferences
as new The ticket will remain with no owner.
Next status will be 'review'.
as The resolution will be set.
to The owner will be changed from (none) to the specified user.
Next status will be 'confirmed'.
The owner will be changed from (none) to anonymous.

Add Comment

E-mail address and name can be saved in the Preferences.

Note: See TracTickets for help on using tickets.