Add CCTK_BUILTIN_TRAP

Roland Haas

changed status to open
removed comment

I have to admit I am not sure I see the need for these functions. On current compilers CCTK_Abort is already declared to have the noreturn attribute so the optimizer knows that it does not have to optimize the code branch that leads to it. In addition CCTK_Abort performs useful cleanup (it call MPI_Abort and can be overloaded by the driver which is not the case when calling a trap.

Maybe the better comparison is really to assert(0) instead? In this case the advantage of the trap is that it cannot be made a no-op by defining NDEBUG.

So I would only want to advertise using the trap for debugging and not in place of CCTK_Abort which provides a fairly "clean" abort route.

2016-07-25T11:57:09+00:00

Comments (4)

Roland Haas
- changed status to open
- removed comment
I have to admit I am not sure I see the need for these functions. On current compilers CCTK_Abort is already declared to have the noreturn attribute so the optimizer knows that it does not have to optimize the code branch that leads to it. In addition CCTK_Abort performs useful cleanup (it call MPI_Abort and can be overloaded by the driver which is not the case when calling a trap.

Maybe the better comparison is really to assert(0) instead? In this case the advantage of the trap is that it cannot be made a no-op by defining NDEBUG.

So I would only want to advertise using the trap for debugging and not in place of CCTK_Abort which provides a fairly "clean" abort route.
- 2016-07-25T11:57:09+00:00
Roland Haas
- changed status to open
- removed comment
- 2016-11-21T12:46:08+00:00
Roland Haas
- changed status to resolved
- removed comment
Merged into master of the flesh in git commit 5348cba8.
- 2017-01-13T08:11:55+00:00
Roland Haas
- edited description
- changed status to closed
- 2019-02-21T19:49:53+00:00
Log in to comment