Modify

Opened 2 years ago

Last modified 2 years ago

#1953 new defect

TOVSolver's TOV_Populate_Timelevels option does not set alp_p, alp_pp or shift_p, shift_pp

Reported by: Roland Haas Owned by:
Priority: minor Milestone:
Component: EinsteinToolkit thorn Version: development version
Keywords: TOVSolver Cc:

Description

TOVSolver offers an option to initialize past timelevels However this seems broken as it does not initialize past timelevels of the lapse and shift (but does eg of the metric).

The code for this is in tov.c where alp_p does not occur at all.

Most likely the option should be deprecated since Carpet's fill_3_timelevels does the same (and similar does MoL's initial_data_is_crap option).

Attachments (0)

Change History (1)

comment:1 Changed 2 years ago by Frank Löffler

TODO: One would need to check how that plays out with post-initial but pre-otherwise-filling code. E.g., does atmosphere handling get called in that time? I would imagine this not being happy about non-initialized hydro. I did find comments with that regard in old parameter files, but don't have time to investigate now:

tovsolver::TOV_Populate_Timelevels = 3 # same as hydrobase, this makes GRHydro_InitialAtmosphereReset in Initial happy

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The ticket will remain with no owner.
Next status will be 'review'.
as The resolution will be set.
to The owner will be changed from (none) to the specified user.
Next status will be 'confirmed'.
The owner will be changed from (none) to anonymous.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.