- removed comment
GetComponents fails if the target path contains a space
Issue #1972
closed
The following fails:
mkdir "Google Drive"
cd "Google Drive"
GetComponents https://bitbucket.org/einsteintoolkit/manifest/raw/ET_2016_05/einsteintoolkit.th
since the git handler (at least) does not properly quote the arguments it passes to git and git complains about too many arguments.
Related to this: GetComponents does not output stderr for failed commands and it likely should (this may involve interfacing with Perl's IPC module).
Keyword:
Comments (6)
-
reporter
-
reporter
- changed status to open
- removed comment
-
- changed milestone to ET_2016_11
- removed comment
Would be nice before the release. Potential big usability improvement, and small patch.
-
- changed status to open
- removed comment
-
- changed status to resolved
- removed comment
-
reporter
- edited description
- changed status to closed
- Log in to comment
- Assignee
- –
- Type
- Priority
- Status
- closed
- Component
- GetComponents
- Milestone
- ET_2016_11
- Version
- development version
- Votes
- 0
- Watchers
- 0
A pull request can be found here: https://github.com/gridaphobe/CRL/pull/2 basically it removes the use of "$orig_dir" (the absolute path of the directory GetComponents was called from) from the script.