Modify

Opened 21 months ago

#2034 new defect

CarpetLib's defs.hh and defs.cc file don't encapsulate defintions in a namespace

Reported by: Roland Haas Owned by: Erik Schnetter
Priority: minor Milestone:
Component: Carpet Version: development version
Keywords: Cc:

Description

CarpetLib's defs.hh and defs.cc do not (as far as I can tell) contain any namespace enclosing the defined functions so that they all end up in the global namespace eg its ipow and also its get_poison_value function. It should however either put them into a CarpetLib namespace or prefix them by CarpetLib_ like other symbols with global linkage.

This apparently has always been the case at least far back as importing carpet-5 into git (5 years ago).

Attachments (0)

Change History (0)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain Erik Schnetter.
Next status will be 'review'.
as The resolution will be set.
to The owner will be changed from Erik Schnetter to the specified user.
Next status will be 'confirmed'.
The owner will be changed from Erik Schnetter to anonymous.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.